Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcepath is not applied correctly with analyzeModifiedFilesOnly #52

Closed
adangel opened this issue Feb 10, 2022 · 0 comments · Fixed by #58
Closed

Sourcepath is not applied correctly with analyzeModifiedFilesOnly #52

adangel opened this issue Feb 10, 2022 · 0 comments · Fixed by #58
Labels
bug Something isn't working
Milestone
v1.2.1

Comments

@adangel
Copy link
Member

adangel commented Feb 10, 2022

If you configure sourcePath: 'src/main/java' and you have sources under src/main/java/** and under src/main/java2/** then the sources under java2 are still analyzed. This is unexpected.

Workaround: sourcePath: 'src/main/java/' (with a trailing slash).

Note: this only is occurs when using "analyzeModifiedFilesOnly: true" (default). When all files are analyzed, then sourcePath is considered correctly.
@adangel adangel added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 10, 2022
@adangel adangel removed help wanted Extra attention is needed good first issue Good for newcomers labels Feb 19, 2022
@adangel adangel mentioned this issue Feb 19, 2022
Merged
@adangel adangel added this to the next milestone Feb 19, 2022
adangel added a commit to pmd/pmd-github-action-tests that referenced this issue Feb 19, 2022
@adangel
Test: Source path is used
2e9d4f9 
pmd/pmd-github-action#52
adangel added a commit that referenced this issue Feb 19, 2022
@adangel
Merge pull request #58 from adangel:issue-52-sourcepath
1039c3f 
Fixes #52 sourcePath without trailing slash #58
@adangel adangel modified the milestone: next Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #52 sourcePath without trailing slash adangel/pmd-github-action
1 participant
@adangel