Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional token parameter #16

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Add optional token parameter #16

merged 2 commits into from
Dec 10, 2021

Conversation

adangel
Copy link
Member

@adangel adangel commented Dec 3, 2021

The token is used for querying GitHub Releases API to determine the
latest PMD version and the download URL for PMD.

This allows to use @actions/github to get a octokit.

Error handling is improved as well - util doesn't catch the errors anymore,
so any exceptions bubble up to the main function.

The token is used for querying GitHub Releases API to determine the
latest PMD version and the download URL for PMD.

This allows to use `@actions/github` to get a octokit.

Error handling is improved as well - util doesn't catch the errors anymore,
so any exceptions bubble up to the main function.
@adangel adangel added this to the next milestone Dec 3, 2021
@adangel
Copy link
Member Author

adangel commented Dec 9, 2021

Looks like this is really required:

Error: API rate limit exceeded for 199.19.85.33. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

@adangel adangel self-assigned this Dec 10, 2021
@adangel adangel merged commit 080b184 into main Dec 10, 2021
@adangel adangel deleted the features/token branch December 10, 2021 10:19
adangel added a commit that referenced this pull request Dec 10, 2021
Was wrong merge of #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant