-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine modified files for pull requests and pushes #24
Commits on Dec 10, 2021
-
Determine modified files for pull requests
That's the first step. The modified files are determined via pull/{pull_number}/files. This API call returns at most 3000 files. We use a page size of 30 and collect at most 10 pages, so that we have a total of 300 files - that's what we use for analyzing. This means for big changes, not all files might be analyzed.
Configuration menu - View commit details
-
Copy full SHA for 1be700c - Browse repository at this point
Copy the full SHA 1be700cView commit details
Commits on Dec 11, 2021
-
Fix input parameter "analyzeModifiedFilesOnly"
Also add logging which mode is active.
Configuration menu - View commit details
-
Copy full SHA for 313aa52 - Browse repository at this point
Copy the full SHA 313aa52View commit details -
Don't execute PMD when no modified files are found
This also sets the output parameter to zero.
Configuration menu - View commit details
-
Copy full SHA for 14becf8 - Browse repository at this point
Copy the full SHA 14becf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5122912 - Browse repository at this point
Copy the full SHA 5122912View commit details -
Configuration menu - View commit details
-
Copy full SHA for 774fc45 - Browse repository at this point
Copy the full SHA 774fc45View commit details -
REVERT ME - Enable debug logging
Usually debug logging is enabled by adding a repository secret "ACTIONS_STEP_DEBUG" with value "true". However, this is secret not available if a PR runs from a forked repository...
Configuration menu - View commit details
-
Copy full SHA for 7f99864 - Browse repository at this point
Copy the full SHA 7f99864View commit details -
Revert "REVERT ME - Enable debug logging"
This reverts commit 7f99864.
Configuration menu - View commit details
-
Copy full SHA for f67f542 - Browse repository at this point
Copy the full SHA f67f542View commit details -
Fix path handling under windows
Let the unit tests run under macos and windows additionally.
Configuration menu - View commit details
-
Copy full SHA for 64cd667 - Browse repository at this point
Copy the full SHA 64cd667View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1216290 - Browse repository at this point
Copy the full SHA 1216290View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08f8d9f - Browse repository at this point
Copy the full SHA 08f8d9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4106851 - Browse repository at this point
Copy the full SHA 4106851View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4211caa - Browse repository at this point
Copy the full SHA 4211caaView commit details
Commits on Dec 13, 2021
-
Determine modified files for pushes
The modified files are determined via compare API call. Similar to pull requests, we only collect at most 10 pages. However, the number of total changed files can't be calculated straightforward, since the pagination happens on the basis of commits rather than files. In any case, for big pushes this means, that not all files might be analyzed.
Configuration menu - View commit details
-
Copy full SHA for ffa00d2 - Browse repository at this point
Copy the full SHA ffa00d2View commit details
Commits on Dec 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 25c2479 - Browse repository at this point
Copy the full SHA 25c2479View commit details -
Log warning when MAX_PAGE is reached
This always logs a warning if we fetched page MAX_PAGE regardless whether there would be more pages to fetch or not. No effort is done to determine whether the list of modified files is complete. Also the modified files are now collected in a Set to avoid duplicate entries.
Configuration menu - View commit details
-
Copy full SHA for 22ebdb5 - Browse repository at this point
Copy the full SHA 22ebdb5View commit details