Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to disable GitHub annotations (createGitHubAnnotations) #45

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Add an option to disable GitHub annotations (createGitHubAnnotations) #45

merged 1 commit into from
Jan 31, 2022

Conversation

smetanink
Copy link
Contributor

@smetanink smetanink commented Jan 28, 2022 •
edited by adangel

Add an option to disable GitHub annotations

A new action input has been added to allow ability to disable adding GitHub annotations.
This can be useful if generated .sarif file is parsing by another tool that also generates annotations.
Annotations will be generated by default for backwards compatibility.

input required default description
createGitHubAnnotations no "true" By default, all detected violations are added as annotations to the pull request. You can disable this by setting FALSE. This can be useful if you are using another tool for this purpose.

@adangel adangel changed the title Add an option to disable GitHub annotations Add an option to disable GitHub annotations (createGitHubAnnotations) Jan 31, 2022
adangel
adangel approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@adangel adangel added this to the next milestone Jan 31, 2022
@adangel adangel added the enhancement New feature or request label Jan 31, 2022
@adangel adangel merged commit 0da8025 into pmd:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smetanink @adangel