Change default to match Effective Java

pmd · May 20, 2016 · 007f9b3 · 007f9b3
1 parent 2ec75e7
commit 007f9b3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pmd-java/src/main/resources/rulesets/java/design.xml b/pmd-java/src/main/resources/rulesets/java/design.xml
@@ -1961,7 +1961,7 @@ better placed in classes or enums. See Effective Java, item 19.
         </description>
         <priority>3</priority>
         <properties>
-        <property name="ignoreIfHasMethods" type="Boolean" description="Whether to ignore constants in interfaces if the interface defines any methods" value="false"/>
+        <property name="ignoreIfHasMethods" type="Boolean" description="Whether to ignore constants in interfaces if the interface defines any methods" value="true"/>
             <property name="xpath">
                 <value>
 <![CDATA[

diff --git a/...src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/ConstantsInInterface.xml b/...src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/ConstantsInInterface.xml
@@ -18,6 +18,7 @@ public interface Foo {
         <description><![CDATA[
 constants in interface, with methods, ignoreIfHasMethods is false
      ]]></description>
+        <rule-property name="ignoreIfHasMethods">false</rule-property>
         <expected-problems>1</expected-problems>
         <code><![CDATA[
 public interface AnotherConstantInterface {