Fix flaky SummaryHTMLRenderer

pmd · Nov 23, 2023 · 49bf440 · 49bf440
1 parent bdc08e4
commit 49bf440
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pmd-core/src/main/java/net/sourceforge/pmd/renderers/SummaryHTMLRenderer.java b/pmd-core/src/main/java/net/sourceforge/pmd/renderers/SummaryHTMLRenderer.java
@@ -5,7 +5,7 @@
 package net.sourceforge.pmd.renderers;
 
 import java.io.IOException;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.Map;
 import java.util.Map.Entry;
 
@@ -74,7 +74,7 @@ private void renderSummary(Report report) throws IOException {
     }
 
     private static Map<String, MutableInt> getSummary(Report report) {
-        Map<String, MutableInt> summary = new HashMap<>();
+        Map<String, MutableInt> summary = new LinkedHashMap<>();
         for (RuleViolation rv : report.getViolations()) {
             String name = rv.getRule().getName();
             MutableInt count = summary.get(name);

diff --git a/pmd-core/src/test/java/net/sourceforge/pmd/renderers/SummaryHTMLRendererTest.java b/pmd-core/src/test/java/net/sourceforge/pmd/renderers/SummaryHTMLRendererTest.java
@@ -69,8 +69,8 @@ String getExpectedMultiple() {
         return "<html><head><title>PMD</title></head><body>" + EOL + "<center><h2>Summary</h2></center>" + EOL
                 + "<table align=\"center\" cellspacing=\"0\" cellpadding=\"3\">" + EOL
                 + "<tr><th>Rule name</th><th>Number of violations</th></tr>" + EOL
-                + "<tr><td>Boo</td><td align=center>1</td></tr>" + EOL
-                + "<tr><td>Foo</td><td align=center>1</td></tr>" + EOL + "</table>" + EOL
+                + "<tr><td>Foo</td><td align=center>1</td></tr>" + EOL
+                + "<tr><td>Boo</td><td align=center>1</td></tr>" + EOL + "</table>" + EOL
                 + "<center><h2>Detail</h2></center><table align=\"center\" cellspacing=\"0\" cellpadding=\"3\"><tr>"
                 + EOL
                 + "<center><h3>PMD report</h3></center><center><h3>Problems found</h3></center><table align=\"center\" cellspacing=\"0\" cellpadding=\"3\"><tr>"