Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] LawOfDemeter: False positive with package-private access #2182

Closed
linusjf opened this issue Dec 22, 2019 · 1 comment · Fixed by #3510
Closed

[java] LawOfDemeter: False positive with package-private access #2182

linusjf opened this issue Dec 22, 2019 · 1 comment · Fixed by #3510
Labels
a:false-positive PMD flags a piece of code that is not problematic
Milestone
7.0.0

Comments

@linusjf
Copy link

linusjf commented Dec 22, 2019 •
edited
Loading

#2160 (comment)

Affects PMD Version:
6.20.0

Rule:
LawOfDemeter.

Description:
Direct access of fields is flagged as static access. Direct access of fields should be permitted when allowed for package-private.

Code Sample demonstrating the issue:

import java.time.LocalDate;

public class Person {
  LocalDate birthday;

  public static int compareByAge(Person a, Person b) {
    return a.birthday.compareTo(b.birthday);
  }
}

Running PMD through: [CLI | Ant | Maven | Gradle | Designer | Other]
@oowekyala oowekyala added a:false-positive PMD flags a piece of code that is not problematic needs-backport labels Feb 16, 2022
@oowekyala oowekyala mentioned this issue Feb 16, 2022
Merged
5 tasks
oowekyala added a commit to oowekyala/pmd that referenced this issue Feb 16, 2022
@oowekyala
Add test cases for fixed issues
e65b119 
- Fixes pmd#2175
- Fixes pmd#2179
- Fixes pmd#1605: same fix as pmd#2179, since enum constants are static fields they are trusted.
- Fixes pmd#2180: the fix is not to special-case Thread, but to consider all static methods as trusted (consistent with the treatment of static fields in pmd#2179)
- Fixes pmd#2182: the fix is not to allow package-private access, but to allow a class to access fields of instances of the same class.
- Fixes pmd#1014
- Fixes pmd#2188
@adangel adangel added this to the 7.0.0 milestone Feb 25, 2022
@adangel adangel changed the title [Java] False positive: LawOfDemeter must permit package-private access. [java] LawOfDemeter: False positive with package-private access Feb 25, 2022
@adangel adangel linked a pull request Feb 25, 2022 that will close this issue
[java] Update LawOfDemeter #3510
Merged
5 tasks
adangel added a commit that referenced this issue Feb 25, 2022
@adangel
[doc] Update release notes for Law Of Demeter (#3510)
f2ac5be 
Issues: #1014 #1605 #2175 #2179 #2180 #2182 #2188
@adangel adangel mentioned this issue Jan 23, 2023
Closed
55 tasks
@jsotuyod
Copy link
Member

This is fixed in PMD 7.0.0-rc1. It won't be backported to PMD 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:false-positive PMD flags a piece of code that is not problematic
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[java] Update LawOfDemeter oowekyala/pmd
4 participants
@jsotuyod @adangel @oowekyala @linusjf