Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] LocalVariableCouldBeFinal should consider blank local variables #3122

Closed
oowekyala opened this issue Feb 19, 2021 · 0 comments · Fixed by #5003
Closed

[java] LocalVariableCouldBeFinal should consider blank local variables #3122

oowekyala opened this issue Feb 19, 2021 · 0 comments · Fixed by #5003
Assignees
@oowekyala
Labels
a:false-negative PMD doesn't flag a problematic piece of code
Milestone
7.2.0

Comments

@oowekyala
Copy link
Member

oowekyala commented Feb 19, 2021 •
edited by jsotuyod
Loading

Affects PMD 7.0.0.

There is a test case for that (currently disabled), see

pmd/pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/LocalVariableCouldBeFinal.xml

Lines 65 to 66 in 28a644c

int c ;
c = a + b;

#3113 (comment)

This requires some sort of control-flow awareness, which could be part of pmd 7.
@oowekyala oowekyala added the a:false-negative PMD doesn't flag a problematic piece of code label Feb 19, 2021
@oowekyala oowekyala added this to the 7.0.0 milestone Feb 19, 2021
@oowekyala oowekyala mentioned this issue Feb 19, 2021
Merged
4 tasks
@oowekyala oowekyala added this to Rule changes backlog in PMD 7 Apr 3, 2021
@oowekyala oowekyala mentioned this issue Apr 7, 2022
Closed
55 tasks
@oowekyala oowekyala mentioned this issue Apr 15, 2022
Closed
2 tasks
@oowekyala oowekyala mentioned this issue May 10, 2022
Closed
@adangel adangel modified the milestones: 7.0.0, 7.x Jan 23, 2023
@adangel adangel removed this from Rule changes backlog in PMD 7 Jan 23, 2023
adangel added a commit to adangel/pmd that referenced this issue Apr 27, 2023
@adangel
[java] LocalVariableCouldBeFinal - update test case (pmd#3122)
47252be
@jsotuyod jsotuyod added the needs:pmd7-revalidation The issue hasn't yet been retested vs PMD 7 and may be stale label Mar 17, 2024
@jsotuyod jsotuyod removed the needs:pmd7-revalidation The issue hasn't yet been retested vs PMD 7 and may be stale label Apr 2, 2024
@oowekyala oowekyala modified the milestones: 7.x, 7.2.0 May 11, 2024
@oowekyala oowekyala self-assigned this May 11, 2024
@oowekyala oowekyala mentioned this issue May 11, 2024
Merged
4 tasks
adangel added a commit that referenced this issue May 31, 2024
@adangel
[doc] Update release notes (#1619, #3122, #5003)
8a8402a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oowekyala oowekyala

Labels
a:false-negative PMD doesn't flag a problematic piece of code
Projects
None yet
Milestone
7.2.0
Development

Successfully merging a pull request may close this issue.

[java] Improve LocalVariableCouldBeFinal oowekyala/pmd
3 participants
@jsotuyod @adangel @oowekyala