Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Deprecate system properties of PMDCommandLineInterface #3299

Closed
oowekyala opened this issue May 25, 2021 · 1 comment · Fixed by #3822
Closed

[core] Deprecate system properties of PMDCommandLineInterface #3299

oowekyala opened this issue May 25, 2021 · 1 comment · Fixed by #3822
Labels
is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them
Milestone
6.44.0

Comments

@oowekyala
Copy link
Member

Followup on #3260

I think we should also deprecate the system properties defined in PMDCommandLineInterface: net.sourceforge.pmd.cli.noExit and net.sourceforge.pmd.cli.status. There's PMD#runPmd which doesn't call System.exit, and ideally PMD#main would always call System.exit. Clients can chose the behavior they want without system properties.
@oowekyala oowekyala added the is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them label May 25, 2021
@oowekyala oowekyala mentioned this issue May 25, 2021
Merged
4 tasks
@adangel adangel added this to the 6.44.0 milestone Mar 8, 2022
@adangel adangel linked a pull request Mar 8, 2022 that will close this issue
[core] Improve PmdAnalysis #3822
Merged
4 tasks
@adangel adangel mentioned this issue Mar 8, 2022
Merged
4 tasks
@oowekyala
Copy link
Member Author

The same thing exists in CPDCommandLineInterface. I think another issue should be forked off to make the relevant deprecations/ improve the CPD programmatic API.

@adangel adangel mentioned this issue Mar 10, 2022
Closed
adangel added a commit to adangel/pmd that referenced this issue Mar 10, 2022
@adangel
[doc] Update release notes (pmd#3299, pmd#3822)
6264092
@adangel adangel mentioned this issue Oct 6, 2022
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them
Projects
None yet
Milestone
6.44.0
Development

Successfully merging a pull request may close this issue.

[core] Improve PmdAnalysis oowekyala/pmd
2 participants
@adangel @oowekyala