Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Add sample java project to regression-tester which uses new language constructs #3431

Closed
adangel opened this issue Jul 30, 2021 · 0 comments · Fixed by #4135
Closed
Labels
an:enhancement An improvement on existing features / rules in:pmd-internals Affects PMD's internals
Milestone

Comments

@adangel
Copy link
Member

adangel commented Jul 30, 2021

Is your feature request related to a problem? Please describe.
We often have rules, that make certain assumptions of the grammar. When we update the grammar to support a new Java version (like #3366), some rules might fail with a NPE (e.g. #3420).

Describe the solution you'd like
We should have a sample project on which pmd is executed by our regression tester, so that we see these problems earlier.

Describe alternatives you've considered

  • Just run PMD in PMDCoverageTest on src/main/resources, where we have some source, that uses the new language - but then we don't run PMD with the proper auxclasspath, as these java files are not compiled. Because of that, some rules might stop early, if the type couldn't be resolved.

Additional context

@adangel adangel added an:enhancement An improvement on existing features / rules in:pmd-internals Affects PMD's internals labels Jul 30, 2021
@adangel adangel added this to the 6.39.0 milestone Aug 20, 2021
@adangel adangel modified the milestones: 6.39.0, 6.40.0 Sep 21, 2021
@adangel adangel modified the milestones: 6.40.0, 6.41.0 Oct 26, 2021
@adangel adangel modified the milestones: 6.41.0, 6.42.0 Nov 18, 2021
@adangel adangel modified the milestones: 6.42.0, 6.43.0 Jan 13, 2022
@adangel adangel modified the milestones: 6.43.0, 6.44.0 Feb 22, 2022
@adangel adangel modified the milestones: 6.44.0, 6.45.0 Mar 24, 2022
@adangel adangel modified the milestones: 6.45.0, 6.46.0 Apr 28, 2022
@adangel adangel modified the milestones: 6.46.0, 6.47.0 May 19, 2022
@adangel adangel modified the milestones: 6.47.0, 6.48.0 Jun 21, 2022
@adangel adangel modified the milestones: 6.48.0, 6.49.0 Jul 26, 2022
@adangel adangel modified the milestones: 6.49.0, 6.50.0 Aug 30, 2022
adangel added a commit to adangel/pmd-regression-tester that referenced this issue Nov 3, 2022
Since PMD 6.50.0 (pmd/pmd#3431) we now have 7 projects for the regression
tester. This PR adjusts the new numbers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
an:enhancement An improvement on existing features / rules in:pmd-internals Affects PMD's internals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant