Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Rename some node types #3751

Closed
Tracked by #3898
oowekyala opened this issue Jan 27, 2022 · 0 comments · Fixed by #4768
Closed
Tracked by #3898

[java] Rename some node types #3751

oowekyala opened this issue Jan 27, 2022 · 0 comments · Fixed by #4768
Assignees
@adangel
Labels
an:enhancement An improvement on existing features / rules in:ast About the AST structure or API, the parsing step
Projects
PMD 7
Milestone
7.0.0

Comments

@oowekyala
Copy link
Member

These renamings should not be done while the PMD 6 branch remains active, as they could introduce more conflicts when merging master back into the pmd 7 branch.

  • ASTClassOrInterfaceType -> ASTClassType
  • ASTClassOrInterfaceDeclaration -> ASTClassDeclaration

These currently match the JLS productions, but we're not the JLS and can use more convenient names.

  • ASTAnyTypeDeclaration -> ASTTypeDeclaration (ASTTypeDeclaration is a node in the current tree but was removed)
  • ASTMethodOrConstructorDeclaration -> ASTExecutableDeclaration
  • AccessNode -> ModifierOwner

This issue was extracted from #2701
@oowekyala oowekyala added the an:enhancement An improvement on existing features / rules label Jan 27, 2022
@oowekyala oowekyala added this to the 7.0.0 milestone Jan 27, 2022
@oowekyala oowekyala added the in:ast About the AST structure or API, the parsing step label Jan 27, 2022
@oowekyala oowekyala mentioned this issue Jan 27, 2022
Closed
@oowekyala oowekyala added this to To do in PMD 7 Jan 27, 2022
@oowekyala oowekyala mentioned this issue Apr 7, 2022
Closed
55 tasks
@adangel adangel mentioned this issue Feb 21, 2023
Closed
@adangel adangel mentioned this issue Dec 11, 2023
Merged
16 tasks
@adangel adangel self-assigned this Dec 11, 2023
adangel added a commit to adangel/pmd that referenced this issue Jan 11, 2024
@adangel
[doc] Update release notes (pmd#1307, pmd#3751)
a1d238c
PMD 7 automation moved this from To do to Done Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adangel adangel

Labels
an:enhancement An improvement on existing features / rules in:ast About the AST structure or API, the parsing step
Projects
No open projects
PMD 7
  
Done
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

[java] Updates to AST nodes adangel/pmd
2 participants
@adangel @oowekyala