Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Split off CLI implementation into a pmd-cli submodule #4079

Closed
Tracked by #2524
oowekyala opened this issue Aug 4, 2022 · 1 comment · Fixed by #4059
Closed
Tracked by #2524

[cli] Split off CLI implementation into a pmd-cli submodule #4079

oowekyala opened this issue Aug 4, 2022 · 1 comment · Fixed by #4059
Labels
an:enhancement An improvement on existing features / rules dependencies Pull requests that update a dependency file in:cli Affects the PMD Command Line Interface
Projects
Milestone

Comments

@oowekyala
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently the PMD and CPD CLI are implemented in pmd-core. This adds dependencies to pmd-core, which could essentially be a library on which PMD clients could rely (the CLI being only one such client).

Describe the solution you'd like
Restrict pmd-core to provide only a programmatic API. Move CLI-related classes and dependencies to a new pmd-cli module. #4059 implements this ticket.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context @jsotuyod found out that this makes implementing #2234 easier.

@oowekyala oowekyala added an:enhancement An improvement on existing features / rules in:cli Affects the PMD Command Line Interface dependencies Pull requests that update a dependency file labels Aug 4, 2022
@oowekyala oowekyala added this to the 7.0.0 milestone Aug 4, 2022
@oowekyala oowekyala linked a pull request Aug 4, 2022 that will close this issue
16 tasks
@oowekyala oowekyala added this to In progress in PMD 7 Aug 4, 2022
@oowekyala oowekyala mentioned this issue Aug 9, 2022
55 tasks
@adangel
Copy link
Member

adangel commented Aug 24, 2022

Note, that this is also beneficial for logging infra: pmd-core can then just be a library, that uses slf4j-api only and the user of pmd-core can then decide, which logging implementation should be used. pmd-cli would then be the "official" user of pmd-core and provide slf4j-simple as a logging implementation.

@adangel adangel mentioned this issue Oct 4, 2022
6 tasks
PMD 7 automation moved this from In progress to Done Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
an:enhancement An improvement on existing features / rules dependencies Pull requests that update a dependency file in:cli Affects the PMD Command Line Interface
Projects
No open projects
PMD 7
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants