Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix finding lambda scope in record compact constructor #4274

Merged

Conversation

kdebski85
Copy link
Contributor

@kdebski85 kdebski85 commented Dec 28, 2022

Describe the PR

Fixes finding lambda scope in record compact constructor

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@kdebski85
Copy link
Contributor Author

I am first-time contributor in this project. Could you please approve running workflow? Can it be added to 6.53.0 milestone?

@jsotuyod
Copy link
Member

@kdebski85 thanks for the PR! at first glance this seems good.

We will still need to double check with PMD 7 before actually closing #4266 even after this is merged into PMD 6. Probably the issue is not present on that branch, but still it won't hurt to check.

@pmd-test
Copy link

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@kdebski85
Copy link
Contributor Author

@jsotuyod I created PR for PMD 7 with a test for this case - #4276
It seems that PMD 7 does not require any changes, but adding a test for it could prevent any regressions in the future.

@adangel adangel added this to the 6.53.0 milestone Dec 31, 2022
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel modified the milestone: 6.53.0 Dec 31, 2022
adangel added a commit that referenced this pull request Dec 31, 2022
adangel added a commit that referenced this pull request Dec 31, 2022
…r-with-lambda

[java] Fix finding lambda scope in record compact constructor #4274
@adangel adangel merged commit c714806 into pmd:master Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] PMD fails to process a record with lambda in compact constructor
4 participants