New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Refactor CPD integration #4323
Comments
I don't think implementing CPD as a rule is viable in the short term (if at all).
|
While it cannot be implemented as a rule yet, the hurdles you mention are the topic of #3920. |
Also I want to eventually implement tree-based copy paste detection which would work by comparing trees instead of tokens. The most reasonable way to implement this is with #3920, because it still requires parsing files. I have an old prototype which gives much higher-quality results than CPD (https://github.com/oowekyala/pmd/tree/tree-clone-detection). This has the same challenges you mention about incremental analysis, but allowing one rule to process all files is not IMO a problem, as long as those rules that don't need to rerun use the violation cache. |
Notes originally from #3809:
The text was updated successfully, but these errors were encountered: