Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dist] Download link broken #4582

Closed
eant60 opened this issue May 31, 2023 · 5 comments
Closed

[dist] Download link broken #4582

eant60 opened this issue May 31, 2023 · 5 comments
Labels
in:documentation Affects the documentation
Milestone

Comments

@eant60
Copy link

eant60 commented May 31, 2023

Download link for latest release pmd-bin-7.0.0-rc3 returns "Not found"

https://github.com/pmd/pmd/releases/download/pmd_releases%2F7.0.0-rc3/pmd-bin-7.0.0-rc3.zip

@jsotuyod
Copy link
Member

Thanks for raising this. It should be https://github.com/pmd/pmd/releases/download/pmd_releases%2F7.0.0-rc3/pmd-dist-7.0.0-rc3-bin.zip after the changes in the dist naming included in the changelog.

@adangel the email included the old format link. I don't recall if this was autogenerated as part of the build or manually set up, we probably missed the change somewhere…

@jsotuyod jsotuyod changed the title download link broken? [dist] Download link broken May 31, 2023
@adangel
Copy link
Member

adangel commented May 31, 2023

@eant60 Thanks for reporting. Yes, I missed that one on pmd.github.io. I'll fix it.

@adangel adangel added the in:documentation Affects the documentation label Jun 1, 2023
@adangel adangel added this to the 7.0.0 milestone Jun 1, 2023
adangel added a commit that referenced this issue Jun 1, 2023
@wroth
Copy link

wroth commented Nov 10, 2023

This still appears broken, albeit in a different way.

The README.md says:
Download the latest binary zip from the releases and extract it somewhere.

Except that link redirects to https://github.com/pmd/pmd/releases/tag/pmd_releases/7.0.0-rc4, which has no link (that I could find) to download the latest binary zip.

I had to get it from https://sourceforge.net/projects/pmd/

@jsotuyod
Copy link
Member

@wroth the link is correct. At the very bottom of that page, there is an Assets section where download links are listed.

You can check it here: https://github.com/pmd/pmd/releases/tag/pmd_releases/7.0.0-rc4#:~:text=22%20other%20contributors-,Assets,-7

image

@dpilafian
Copy link
Contributor

For anyone who automates the download, here's what you need to know:

https://github.com/pmd/pmd/releases/download/pmd_releases%2F[VERSION]/pmd-bin-[VERSION].zip       //OLD
https://github.com/pmd/pmd/releases/download/pmd_releases%2F[VERSION]/pmd-dist-[VERSION]-bin.zip  //NEW

Also, the name of the script in the zip file changed:

$ ./pmd-bin-[VERSION]/bin/run.sh pmd ...  //OLD
$ ./pmd-bin-[VERSION]/bin/pmd check ...   //NEW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:documentation Affects the documentation
Projects
None yet
Development

No branches or pull requests

5 participants