Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] GuardLogStatement regression #783

Closed
boris-petrov opened this issue Dec 16, 2017 · 1 comment
Closed

[java] GuardLogStatement regression #783

boris-petrov opened this issue Dec 16, 2017 · 1 comment
Assignees
@adangel
Labels
a:false-positive PMD flags a piece of code that is not problematic
Milestone
6.0.1

Comments

@boris-petrov
Copy link
Contributor

boris-petrov commented Dec 16, 2017 •
edited by adangel

Affects Version: 6.0.0

if (!(exception instanceof IllegalArgumentException) && LOGGER.isErrorEnabled()) {
	LOGGER.error("Some error " + someObject, exception);
}

The following code gives a GuardLogStatement warning while it shouldn't.
@adangel adangel added the a:false-positive PMD flags a piece of code that is not problematic label Dec 16, 2017
@adangel
Copy link
Member

adangel commented Dec 16, 2017

Thanks for testing the new release and the report.

@adangel adangel added this to the 6.1.0 milestone Dec 16, 2017
@jsotuyod jsotuyod modified the milestones: 6.1.0, 6.0.1 Dec 20, 2017
@adangel adangel changed the title [java] [6.0.0] GuardLogStatement regression [java] GuardLogStatement regression Dec 20, 2017
@adangel adangel self-assigned this Dec 23, 2017
adangel added a commit to adangel/pmd that referenced this issue Dec 24, 2017
@adangel
[java] Rewrite GuardLogStatementRule without XPath
4700692 
- uses now a Java only implementions
- Fixes pmd#783
@adangel adangel mentioned this issue Dec 24, 2017
Merged
@adangel adangel added the has:pr label Dec 24, 2017
@jsotuyod jsotuyod mentioned this issue Jan 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adangel adangel

Labels
a:false-positive PMD flags a piece of code that is not problematic
Projects
None yet
Milestone
6.0.1
Development

No branches or pull requests
3 participants
@boris-petrov @jsotuyod @adangel