[apex] Remove apex statistical rules #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
jsotuyod
reviewed
Apr 10, 2019
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/design/AbstractCounterCheckRule.java
Outdated
Show resolved
Hide resolved
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/design/AbstractCounterCheckRule.java
Outdated
Show resolved
Hide resolved
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/design/AbstractCounterCheckRule.java
Outdated
Show resolved
Hide resolved
jsotuyod
added
the
is:WIP
jsotuyod
approved these changes
Apr 11, 2019
jsotuyod
removed
the
is:WIP
13 tasks
This was referenced Jan 10, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts removing statistical rules from the codebase, refs #1550, #1432
This simplifies the existing rules very much, with the new base class AbstractCounterCheckRule. I kept it package private since its only purpose is to eliminate some duplication (and sync the name of the property). The common logic is so simple that anyone can implement it themselves in a few lines.
One difference between the refactored rules and their 6.0.0 version is that the "minimum" property is now an integer instead of a double, so property sets with eg "1.0" won't work anymore. This is expected though, nearly all our metrics are integers.
After this PR the other language modules can be done in parallel, those depend on the "CommonPropertyDescriptors" internal class in pmd-core.