New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Deprecate AST internal API #1846
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this soon. I've added a couple of more deprecations, especially, I also deprecated+internalized the constructors of the (now deprecated) abstract base classes.
This is not urgent on the 7.0.0 branch though
Not necessarily, but the sooner, the better: Ideally, we would only make methods package private in PMD 7, that are already deprecated. I guess, that we will get some merge conflicts, when merging master -> pmd/7.0.x or java-grammar the next time...
Deprecates and marks
@InternalApi
in the Java AST:Also removes trash JJTree comments. Nodes can then inherit a better documentation on their jjtAccept method for example.
@jsotuyod The plan is to make those package-private if possible, otherwise internal API. This is not urgent on the 7.0.0 branch though. The next steps for the
java-grammar
branch arefoo()()::b()
)