[core] Fix IOException loading rulesets under concurrency #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsotuyod
force-pushed
the
issue-234
branch
3 times, most recently
from
7f0bbdc
to
2f8f73d
Compare
|
I've no idea why Jacoco has big issues with the changes done to PMD.java on this commit... totally weird, makes no sense.... I'm still investigating. |
- Fixes pmd#234 - When a single JVM runs multiple PMD instances under different threads, connections to PMD jars (and streams opened to read standard rulesets) are shared, causing race conditions where one thread may cause the other to close it's streams. This in tun produces IOExceptions. - This happens in Gradle when enabling parallel builds. I believe it can happen under Maven with -T1C too, but has not been able to reproduce it. - I take the chance to clean up classloader closing code, making it more concise and standard accross CLI and Ant.
|
Figured it out! Would never have guessed it... Added a nice comment for future self. |
|
Thanks! It's merged into pmd/5.4.x, pmd/5.5.x and master branches. |
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Feb 12, 2017
…nt Task Got lost, when pmd#235 was rebased onto pmd/5.4.x
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Feb 12, 2017
…nt Task Got lost, when pmd#235 was rebased onto pmd/5.4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connections to PMD jars (and streams opened to read standard rulesets)
are shared, causing race conditions where one thread may cause the other
to close it's streams. This in tun produces IOExceptions.
under Maven with -T1C too, but has not been able to reproduce it.
This bug was introduced in PMD 5.5.1 and 5.4.2, when we fixed the leaked file handlers.