[core] Remove DFA #2696
Merged
[core] Remove DFA #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
Note for later: the build fails because release_notes.md links to the remove rule (DataflowAnomalyAnalysis). When 6.27.0 is out we can merge this, as those release notes will be moved to release_notes_old, and the html link may be removed. We probably need a better way to handle rule removal. For example, whitelisting references to removed rules in RuleTagChecker. The problem is the link would still be generated by Liquid, and it would be dead. |
This will cause a merge conflict after the PMD 6.27.0 release.
adangel
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Remove the classes deprecated in #2681 and their tests.
Related issues
dfa.reportpackage (ViolationTree)Ready?
./mvnw clean verifypasses (checked automatically by travis)