Finish reworking CLI with JCommander #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inside the directory
…tly to simplify and clarifiy PMD main class code.
sgorbaty
pushed a commit
to sgorbaty/pmd
that referenced
this pull request
Jan 12, 2017
jsotuyod
referenced
this pull request
in Monits/pmd
Jan 13, 2017
KroArtem
referenced
this pull request
in KroArtem/pmd
May 4, 2020
JonnyPower
referenced
this pull request
in Traction-Rec/pmd
Jan 12, 2022
[apex] New Rule: override equals and hashcode rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I've finished rework PMD CLI using JCommander - I got ride of 4 classes in the process (and only added a small one). I think it is cleaner like that, but - more importantly, we no longer need those horrible string parsing classes (where we try to figure out which argument were actually passed to PMD).
@andreas: Again, as a matter of principal, I would like some code review by you before pushing it to the main repository.