Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Make unused rules ignore some names #3066

Merged
merged 2 commits into from Jan 22, 2021
Merged

[java] Make unused rules ignore some names #3066

merged 2 commits into from Jan 22, 2021

Conversation

oowekyala
Copy link
Member

@oowekyala oowekyala commented Jan 16, 2021 •
edited by adangel

This PR fixes #2957.

The following rules are affected:

The following variable names are ignored:

  • any name starting with ignored, e.g. ignoredParameter
  • any name starting with unused, e.g. unusedVar

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 6.31.0 milestone Jan 16, 2021
@oowekyala oowekyala mentioned this pull request Jan 16, 2021
Closed
@adangel adangel self-assigned this Jan 21, 2021
@adangel adangel mentioned this pull request Jan 22, 2021
Closed
@adangel adangel added the an:enhancement An improvement on existing features / rules label Jan 22, 2021
@adangel adangel merged commit c69f7e9 into pmd:master Jan 22, 2021
@oowekyala oowekyala deleted the java-unused-names branch January 22, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adangel adangel

Labels
an:enhancement An improvement on existing features / rules
Projects
None yet
Milestone
6.31.0
Development

Successfully merging this pull request may close these issues.

[java] Ignore unused declarations that have special name
2 participants
@oowekyala @adangel