[java] Improve rule UnnecessaryReturn to detect more cases #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
oowekyala
force-pushed
the
update-UnnecessaryReturn
branch
from
9dac040
to
b23330d
Compare
adangel
changed the title
adangel
approved these changes
Apr 10, 2021
| /** | ||
| * Returns true if the node is the last child of its parent (or is the root node). | ||
| */ | ||
| public static boolean isLastChild(Node it) { |
There was a problem hiding this comment.
This might be a candidate for Node itself... But that's for a separate PR/issue (Node API)
adangel
added a commit
that referenced
this pull request
Apr 10, 2021
adangel
added a commit
that referenced
this pull request
Apr 10, 2021
[java] Improve rule UnnecessaryReturn to detect more cases #3195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Update UnnecessaryReturn. The rule is more general than before, so I guess there will be fps to find out. But it will also be much more useful. Namely it now checks return statements in initializers, constructors, and lambdas properly. Also it doesn't flag just a return statement at the very end of a method, which is exceedingly rare and useless, but recurses to find out whether we're at the end of the control flow graph of the method. So it should handle arbitrarily complex code.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)