Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apex] Check SOQL CRUD on for loops #3367

Merged
merged 2 commits into from Jul 2, 2021
Merged

[apex] Check SOQL CRUD on for loops #3367

merged 2 commits into from Jul 2, 2021

Conversation

jonathanwiesel
Copy link
Contributor

Describe the PR

Report SOQL CRUD check absence on for-loops

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel changed the title Check SOQL CRUD on for loops [apex] Check SOQL CRUD on for loops Jul 2, 2021
@adangel adangel added this to the 6.37.0 milestone Jul 2, 2021
@adangel adangel self-assigned this Jul 2, 2021
adangel
adangel approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

About the failing build:
the build is failing, because we shallow clone the repo only and PR base is 66 commits behind master - we only fetch 50 commits.... so make sure, to update your fork at https://github.com/jonathanwiesel/pmd/ (which is currently 245 commits behind pm/pmd) before you create a new PR :)

adangel added a commit that referenced this pull request Jul 2, 2021
@adangel
[doc] Update release notes (#3329, #3367)
94a16e3
adangel added a commit that referenced this pull request Jul 2, 2021
@adangel
Merge pull request #3367 from jonathanwiesel:apex-crud-forloop
ff5deed 
[apex] Check SOQL CRUD on for loops #3367
@adangel adangel merged commit ac238e1 into pmd:master Jul 2, 2021
@jonathanwiesel
Copy link
Contributor Author

Thanks!

About the failing build:
the build is failing, because we shallow clone the repo only and PR base is 66 commits behind master - we only fetch 50 commits.... so make sure, to update your fork at https://github.com/jonathanwiesel/pmd/ (which is currently 245 commits behind pm/pmd) before you create a new PR :)

That explains a lot, thanks a lot @adangel, and sorry for the inconvenience

@jonathanwiesel jonathanwiesel deleted the apex-crud-forloop branch July 2, 2021 08:26
@jfeingold35 jfeingold35 mentioned this pull request Aug 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees

@adangel adangel

Labels
None yet
Projects
None yet
Milestone
6.37.0
Development

Successfully merging this pull request may close these issues.

[apex] ApexCRUDViolation doesn't report SOQL for loops
2 participants
@jonathanwiesel @adangel