Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix #3701 - fix MissingStaticMethodInNonInstantiatableClass for method local classes #3742

Merged
merged 1 commit into from Jan 17, 2022

Conversation

dykov
Copy link

@dykov dykov commented Jan 15, 2022

Describe the PR

Fixed MissingStaticMethodInNonInstantiatableClass for method local classes:

public class Foo {
    void method() {

        class InnerClass {
            private InnerClass() {
            }
        }

        InnerClass innerClass = new InnerClass();
    }
}

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

1 Message
📖 This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel added this to the 6.42.0 milestone Jan 17, 2022
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel merged commit 420505a into pmd:master Jan 17, 2022
adangel added a commit to adangel/pmd that referenced this pull request Jan 17, 2022
adangel added a commit that referenced this pull request Jan 17, 2022
[java] Fix #3701 - fix MissingStaticMethodInNonInstantiatableClass for
method local classes #3742

* pr-3742:
  [doc] Update release notes (#3701, #3742)
  #3701 - fix MissingStaticMethodInNonInstantiatableClass for method
local classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] MissingStaticMethodInNonInstantiatableClass false positive with method inner classes
3 participants