[ci] GitHub Workflows security hardening #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex <aleksandrosansan@gmail.com>
Signed-off-by: Alex <aleksandrosansan@gmail.com>
oowekyala
changed the title
adangel
reviewed
Sep 30, 2022
There was a problem hiding this comment.
Thanks for the PR!
I think for the build.yml workflow, we need also write access for contents. We use currently this workflow for everything: building from PRs, building from pushes, building from pushes to tags. And that creates a new release. We also update the branch "gh-pages" during the build, that means, we do a git-push against the our repo.
I have some idea in mind to refactor the workflow to make it into smaller chunks, but that's out of scope for now.
Generated by 🚫 Danger |
|
I see, you are right. |
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Sep 30, 2022
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Sep 30, 2022
[ci] GitHub Workflows security hardening pmd#4130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from
on: pull_requestfrom external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.