[java] Fixes 3859: Exclude junit5 test methods from the commentDefaultAccessModifierRule #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tAccessModifierRule
There was a conflict between the CommentDefaultAccessModifier and the JUnit5TestShouldBePackagePrivate rule. while the JUnit5TestShouldBePackagePrivate rule passed, the CommentDefaultAccessModifier complained about the lack of a comment on the method encapsulation generating a false alert.
example "@org.junit.jupiter.api.Test void MissingCommentMethod {}", missing " /* default */" but not required in junit5.
The changes will exclude methods with junit5 @test or @ParameterizedTest annotation for the commentDefaultAccessModifierRule.
adangel
approved these changes
Sep 29, 2022
.../resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/CommentDefaultAccessModifier.xml
Outdated
Show resolved
Hide resolved
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/types/TestingFrameworkTypeUtil.java
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger |
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Sep 29, 2022
…default-access-modifier [java] Fixes 3859: Exclude junit5 test methods from the commentDefaultAccessModifierRule pmd#4137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
There was a conflict between the CommentDefaultAccessModifier and the JUnit5TestShouldBePackagePrivate rule. while the JUnit5TestShouldBePackagePrivate rule passed, the CommentDefaultAccessModifier complained about the lack of a comment on the method encapsulation generating a false alert.
example
@org.junit.jupiter.api.Test void MissingCommentMethod {}", missing " /* default */but not required in junit5.The changes will exclude methods with junit5 @test or @ParameterizedTest annotation for the commentDefaultAccessModifierRule.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)