Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] fix #4141 Update UncommentedEmptyConstructor - ignore @Autowired annotations #4142

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Conversation

LynnBroe
Copy link
Contributor

@LynnBroe LynnBroe commented Oct 5, 2022

Describe the PR

I reivise the rule UncommentedEmptyConstructor and make the annotation @Autowired can be detected

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

pmd-test commented Oct 5, 2022

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 2 violations, 2 errors and 7 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel changed the title fix #4141 Update UncommentedEmptyConstructor - ignore @Autowired annotations [java] fix #4141 Update UncommentedEmptyConstructor - ignore @Autowired annotations Oct 6, 2022
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@adangel adangel added this to the 6.51.0 milestone Oct 6, 2022
adangel added a commit to adangel/pmd that referenced this pull request Oct 6, 2022
adangel added a commit to adangel/pmd that referenced this pull request Oct 6, 2022
[java] fix pmd#4141 Update UncommentedEmptyConstructor - ignore @Autowired annotations pmd#4142
@adangel adangel merged commit a1bcad2 into pmd:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[java] UncommentedEmptyConstructor FP when constructor annotated with @Autowired
3 participants