Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apex] Summit-AST Apex module - Part 3 - initializers #4171

Merged
merged 7 commits into from Nov 10, 2022
Merged

[apex] Summit-AST Apex module - Part 3 - initializers #4171

merged 7 commits into from Nov 10, 2022

Conversation

aaronhurst-google
Copy link
Contributor

@aaronhurst-google aaronhurst-google commented Oct 20, 2022 •
edited by oowekyala

Build and translate nodes related to variable declaration initializers.

Ref #3766

eklimo and others added 7 commits October 17, 2022 03:23
@eklimo @aaronhurst-google
Build constructor initializers
989ea03 
Change-Id: I6c4bc34a85e80302da8ef4043a65b7cbec426ee1
@eklimo @aaronhurst-google
Build values initializers
34d540f
@eklimo @aaronhurst-google
Build map initializers
3b609c5
@eklimo @aaronhurst-google
Build sized array initializers
543a111
@eklimo @aaronhurst-google
Fix buildMapEntry
c9cd6e3
@aaronhurst-google
Post-merge fixups.
96d10a9 
Make AST node constructors package-private.
Cleanup imports.
@aaronhurst-google
Merge branch 'part-3' into experimental-apex-parser
828ccd1 
Change-Id: Ibaef3a59307633647129b4971a382ee85a5c0d53
@adangel adangel mentioned this pull request Oct 25, 2022
Closed
16 tasks
@adangel adangel changed the title Summit-AST Apex module - Part 3 - initializers [apex] Summit-AST Apex module - Part 3 - initializers Oct 25, 2022
@aaronhurst-google
Copy link
Contributor Author

Hi @adangel... to give you some forward visibility. I've got the following changes lined up:

  • Part 4 - statements
  • Part 5 - annotations. (This completes the skeleton of the translation. All the node types are at least partially handled.)
  • Some test and TODO fixes from @eklimo

After that, I'll be continuing to burn down the test suite failures and TODOs.

adangel
adangel approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

I'll merge it into experimental-apex-parser.

@adangel adangel merged commit b75c700 into pmd:experimental-apex-parser Nov 10, 2022
@adangel adangel added this to the 7.0.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aaronhurst-google @adangel @eklimo