Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Clarify Scala support (no built-in rules) #4205

Merged
merged 1 commit into from
Nov 11, 2022
Merged

[doc] Clarify Scala support (no built-in rules) #4205

merged 1 commit into from
Nov 11, 2022

Conversation

Eldrick19
Copy link
Contributor

@Eldrick19 Eldrick19 commented Nov 10, 2022 •
edited by adangel
Loading

Describe the PR

Mini-PR to add some clarity around Scala support until rules are added

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@Eldrick19 Eldrick19 marked this pull request as ready for review November 10, 2022 23:37
@adangel adangel changed the title Provide Scala Update [doc] Provide Scala Update Nov 11, 2022
@adangel adangel added the in:documentation Affects the documentation label Nov 11, 2022
@adangel adangel added this to the 6.52.0 milestone Nov 11, 2022
@adangel adangel mentioned this pull request Nov 11, 2022
Open
@adangel adangel changed the title [doc] Provide Scala Update [doc] Clarify Scala support (no built-in rules) Nov 11, 2022
adangel added a commit to adangel/pmd that referenced this pull request Nov 11, 2022
@adangel
[doc] List all languages in rule doc
02ad552 
Even without rules.

- Relates pmd#4205
- Relates pmd#4105
@adangel adangel mentioned this pull request Nov 11, 2022
Merged
adangel
adangel approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll merge it (but revert the unrelated change to package-lock.json)

adangel added a commit that referenced this pull request Nov 11, 2022
@adangel
[doc] Update release notes (#4205)
43aa917
adangel added a commit that referenced this pull request Nov 11, 2022
@adangel
Merge pull request #4205 from Eldrick19:eldrick19-scala-clarification
2092ea2 
[doc] Clarify Scala support (no built-in rules) #4205
@adangel adangel merged commit ed1e84e into pmd:master Nov 11, 2022
@Eldrick19 Eldrick19 deleted the eldrick19-scala-clarification branch November 11, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
in:documentation Affects the documentation
Projects
None yet
Milestone
6.52.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eldrick19 @adangel