Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apex] Summit-AST Apex module - Part 6 Passing testsuite #4251

Merged

Commits on Dec 1, 2022

  1. Fix b/243743042

    Fix an unexpected `RuntimeException` from
    `AbstractApexNodeBase.getBeginColumn` in instances where a `Node` had a
    start column of `0`.
    eklimo authored and aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    90aec7a View commit details
    Browse the repository at this point in the history
  2. Fix b/243747010

    Set `ASTMethod.getImage` to name of type for constructors
    eklimo authored and aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    9e5d4d4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c6ad8fb View commit details
    Browse the repository at this point in the history
  4. Update TODO comments

    Change-Id: I033160534044936ac2ec416428662024b63e8c5f
    eklimo authored and aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    da9e1ef View commit details
    Browse the repository at this point in the history
  5. Fix b/243977405

    - Don't build the `exceptionVariable` property of `CatchBlock` nodes.
      Some rules (e.g. `LocalVariableNamingConventionsRule`) expect the
      parent of every `ASTVariableDeclaration` to be an
      `ASTVariableDeclarationStatements`.
    - Fix `LocalVariableNamingConventionsRule` crash.
    eklimo authored and aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    1f438e6 View commit details
    Browse the repository at this point in the history
  6. Upgrade Summit to 1.1.0 (snapshot).

    Make updates related to new VariableDeclarationGroup.
    
    Translate SOQL and SOSL expressions and bindings.
    
    Change-Id: I18995800e292cabe9f61176fa7aefedfc9729def
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    4fbe0de View commit details
    Browse the repository at this point in the history
  7. Add back ApexTreeBuilder.java.

    Change-Id: I6fb29b07e3679f333cae37fe28dfd8b14c8d4a20
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    157558c View commit details
    Browse the repository at this point in the history
  8. Translate EnumValue node to ASTField.

    Change-Id: Iec7c8335b966b243a63243ad631193b82598808b
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    fb32ba3 View commit details
    Browse the repository at this point in the history
  9. Rename former ApexTreeBuilder.java to ApexCommentBuilder.java.

    Change-Id: I662171da66517235ce30a701ed84b687edfdb3a3
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    611d788 View commit details
    Browse the repository at this point in the history
  10. Comments!

    * ASTFormalComments: represent and build.
    * Mark comment containers
    * Populate suppression map
    
    This reuses the existing code to the extent possible.
    
    Makes ApexDocTest pass.
    
    Change-Id: I5843ffa9174f7f501aae551e5d493ee973c3dd45
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    581d4d6 View commit details
    Browse the repository at this point in the history
  11. Comment position fixup

    Change-Id: I06a3bc7afce01d2050c46aa2ca674a7a91fc4c5a
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    701fb53 View commit details
    Browse the repository at this point in the history
  12. Replicate previous behavior for type names:

    * Case normalize primitive types (e.g. Integer)
    * Use type-erased names for super classes and interfaces
    * Include type arguments for all other uses
    
    Add documentation.
    
    Change-Id: I9edf979c58a5fcf6f251e93013be85fea22a8be1
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    ff9de70 View commit details
    Browse the repository at this point in the history
  13. Fix test failures related to Boolean cognitive complexity due to (unn…

    …ecessarily) disabled code.
    
    Change-Id: I45fab6872f5a69910452b6ac2429716b677bd93a
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    914f6a8 View commit details
    Browse the repository at this point in the history
  14. Fix test failure due to incorrect case-sensitive identifier comparison.

    Change-Id: I232b8e7ad0ffc5f9ac8beab741e48d90b24063d4
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    ecad878 View commit details
    Browse the repository at this point in the history
  15. Update TreeDumper regression test with Summit AST output.

    Change-Id: I92b456c124c50ceb20416d69b1d88d0b5405dd89
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    0524d66 View commit details
    Browse the repository at this point in the history
  16. Update test to use getOp replacement for deprecated and now retired g…

    …etOperator.
    
    Change-Id: I1fdfc314ede7ccfcfe3e169acaef309ba07c17c1
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    072bb72 View commit details
    Browse the repository at this point in the history
  17. Upgrade Summit AST dependency to release version 2.0.0.

    Update code to remove reference to deleted MODULO operator.
    
    Change-Id: I39d9f7adc0407aafa9af31d3b2253c6c37c735b1
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    6897164 View commit details
    Browse the repository at this point in the history
  18. Update test with Jorje vs. Summit source location and node count diff…

    …erences.
    
    Re-enable some tests that were disabled due to Jorje limitations.
    
    Change-Id: Id81582231afcc3b2e9f13ac52860ac0de538f41b
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    19225dc View commit details
    Browse the repository at this point in the history
  19. Remove pmd-visualforce Jorje dependency.

    Change-Id: Id580cdfa39b4288c239a496ed4a61afb123b0b2f
    aaronhurst-google committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    d57d482 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. Refactor ASTMethod to support synthetic definitions, and add a synthe…

    …tic "invoke" method inside triggers.
    
    Change-Id: I21344a36c9795deffd9c62aa0e768eb6f6742796
    aaronhurst-google committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    62080c6 View commit details
    Browse the repository at this point in the history
  2. ASTField: store String type name instead of either typeRef or enumVal…

    …ue node.
    
    Change-Id: I1542cdd3da3675a04f36c0b0627ea837e2005ac3
    aaronhurst-google committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    9fef04f View commit details
    Browse the repository at this point in the history
  3. Fix PMD dogfood issues.

    Change-Id: I3371e80418e11766657e7f461d26f440fcd78e79
    aaronhurst-google committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    8734d45 View commit details
    Browse the repository at this point in the history
  4. Fix checkstyle violations.

    Change-Id: I6c371bdecaf08d306bee7308e94f2f1bc5ef0e4c
    aaronhurst-google committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    16a492f View commit details
    Browse the repository at this point in the history
  5. Change case normalization of primitive from 'ID' to 'Id' to match exi…

    …sting behavior.
    
    Change-Id: I7b3406a60bbc18dc2b1e441b8c0122452f709404
    aaronhurst-google committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    e9eafdd View commit details
    Browse the repository at this point in the history
  6. Property getter and setter methods default to visibility of property.

    Change-Id: Ib8d4a2d5941b47c47cbd469c1af5ab5f405b120f
    aaronhurst-google committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    6d35496 View commit details
    Browse the repository at this point in the history
  7. Update tested return type name to match Summit, which returns the syn…

    …tactic type name.
    
    Change-Id: I6ea22b890e60f24c2684f85753223f240e33509a
    aaronhurst-google committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    1a5c571 View commit details
    Browse the repository at this point in the history
  8. Move guava to a non-test dependency, due to implicit dependencies tha…

    …t were previous satisfied by copy inside Jorje JAR.
    
    Change-Id: Iebbc77d4f1ece8ec4712f749356d877858c14d21
    aaronhurst-google committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    626aec5 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Update pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ast/ASTLi…

    …teralExpression.java
    
    Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
    aaronhurst-google and adangel committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    8745d00 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60da7bd View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Configuration menu
    Copy the full SHA
    656dff9 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Remove ApexRootNode.getApexVersion.

    The deprecation was proposed for master/pmd6.
    aaronhurst-google committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    b4b9dd2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58ca81d View commit details
    Browse the repository at this point in the history
  3. Sort children of ASTUserClass to order ASTField nodes earlier, immedi…

    …ately after modifiers.
    
    This matches one observed property in the way that Jorje ordered nodes.
    
    Update the dump test.
    aaronhurst-google committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ebb861a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8ccafa View commit details
    Browse the repository at this point in the history