-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for T-SQL using Antlr4 lexer #4390
Conversation
c5da421
to
d20592b
Compare
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Amazing!
Please have a look at my comments.
pmd-tsql/src/main/java/net/sourceforge/pmd/cpd/TSqlLanguage.java
Outdated
Show resolved
Hide resolved
pmd-tsql/src/main/antlr4/net/sourceforge/pmd/lang/tsql/antlr4/TSqlLexer.g4
Outdated
Show resolved
Hide resolved
pmd-tsql/src/main/antlr4/net/sourceforge/pmd/lang/tsql/antlr4/TSqlLexer.g4
Outdated
Show resolved
Hide resolved
pmd-tsql/src/main/java/net/sourceforge/pmd/cpd/TSqlTokenizer.java
Outdated
Show resolved
Hide resolved
pmd-tsql/src/main/java/net/sourceforge/pmd/lang/tsql/TSqlLanguageModule.java
Outdated
Show resolved
Hide resolved
pmd-tsql/src/main/java/net/sourceforge/pmd/lang/tsql/antlr4/package-info.java
Outdated
Show resolved
Hide resolved
pmd-tsql/src/main/resources/META-INF/services/net.sourceforge.pmd.cpd.Language
Outdated
Show resolved
Hide resolved
pmd-tsql/src/main/resources/META-INF/services/net.sourceforge.pmd.lang.Language
Outdated
Show resolved
Hide resolved
945ac4f
to
e113079
Compare
It works locally with but not on the CI where several classes cannot be instantiated. https://github.com/pguyot/pmd/actions/runs/4191715718/jobs/7266434608#step:7:8278 |
e113079
to
e9eca6c
Compare
7e31286
to
c9b19b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
Add support for T-SQL using Antlr4 lexer #4390
Describe the PR
This pull request adds CPD support for T-SQL language using the Antlr4 grammar, following tutorial.
The grammar is taken from https://github.com/antlr/grammars-v4/tree/master/sql/tsql
Ready?
./mvnw clean verify
passes (checked automatically by github actions)