[java] Fix #4393 MissingStaticMethodInNonInstantiatableClass: Fix false-positive for field-only class

[dawiddc]

Describe the PR

This PR fixes false-positive lombok's UtilityClass MissingStaticMethodInNonInstantiatableClass check for classes that have non-private fields without non-private methods inside.

Related issues

• Fixes [java] MissingStaticMethodInNonInstantiatableClass false-positive for Lombok's @UtilityClass for classes with non-private fields #4393

Ready?

• Added unit tests for fixed bug/feature
• Passing all unit tests
• Complete build ./mvnw clean verify passes (checked automatically by github actions)
• Added (in-code) documentation (if needed)

[adangel]

Thanks for the PR!

Could you please create a new bug report/issue for the false positive? We can't reuse #4224, since that is already closed...
And the new case you found is a new bug (although maybe introduced by #4224).

[pmd-test]

	1 Message
📖	Compared to master: This changeset changes 0 violations, introduces 0 new violations, 0 new errors and 0 new configuration errors, removes 0 violations, 2 errors and 7 configuration errors. Full report
✅	Compared to master: This changeset changes 0 violations, introduces 0 new violations, 0 new errors and 0 new configuration errors, removes 0 violations, 2 errors and 7 configuration errors. Full report

Generated by 🚫 Danger

[dawiddc]

Thanks for the PR!

Could you please create a new bug report/issue for the false positive? We can't reuse #4224, since that is already closed... And the new case you found is a new bug (although maybe introduced by #4224).

Thanks, issue created and re-linked PR name/desc to #4393

[adangel]

Thanks!