Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove PMD.EOL #4420

Merged
merged 9 commits into from
Mar 17, 2023
Merged

Conversation

oowekyala
Copy link
Member

Describe the PR

This is one of the last remaining reasons the class PMD is needed. Once that's gone we can probably remove PMD and the old CLI in pmd-core without too much trouble.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added the is:feature-removal Remove an unneeded unused feature label Mar 14, 2023
@oowekyala oowekyala added this to the 7.0.0 milestone Mar 14, 2023
@oowekyala oowekyala added this to In progress in PMD 7 via automation Mar 14, 2023
@pmd-test
Copy link

pmd-test commented Mar 15, 2023

1 Message
📖 Compared to master:
This changeset changes 10 violations,
introduces 2 new violations, 0 new errors and 0 new configuration errors,
removes 2 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel self-requested a review March 16, 2023 10:24
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll push some minor changes and merge it, once the build is green.

@adangel adangel merged commit 4a14cb7 into pmd:master Mar 17, 2023
PMD 7 automation moved this from In progress to Done Mar 17, 2023
@oowekyala oowekyala deleted the clem.pmd7-remove-pmd-eol branch March 17, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature-removal Remove an unneeded unused feature
Projects
No open projects
PMD 7
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants