[java] Fix #4449 AvoidAccessibilityAlteration: Correctly handle Lambda expressions in PrivilegedAction scenarios #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
adangel
approved these changes
Apr 3, 2023
| @@ -184,4 +184,39 @@ public class Violation { | |||
| } | |||
| ]]></code> | |||
| </test-code> | |||
|
|
|||
| <test-code> | |||
| <description>setAccessible is ok in LambdaExpression</description> | |||
There was a problem hiding this comment.
Suggested change
| <description>setAccessible is ok in LambdaExpression</description> | |
| <description>#4449 setAccessible is ok in LambdaExpression</description> |
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR addresses a false positive in the AvoidAccessibilityAlteration rule when using Lambda expressions with PMD 7.0. The update includes changes to the XPath rule to handle Lambda expressions correctly and avoid false positives.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)