[apex] Merge main (7.x) branch into experimental-apex-parser and fix tests

[aaronhurst-google]

Part of #3766

Merge main (7.x) branch into experimental-apex-parser and fix tests.

Conflict resolution and fixes include:
* Create root ASTApexFile nodes
* Correct source locations
* Insert comments by offset rather than line/column, using more of the mainline code
* Removed some unused methods
* Suppress Summit logger INFO output
* Suppress some (but not all) ANTLR version mismatch output
* Replace ASTFormalComment.getToken() with getImage()
* Remove deleted APIs: getLocation, hasSuppressWarningsAnnotationsFor, getModifiers
* Remove code that was factored into BaseApexClass
* Replace all references to Jorje in rules
* Passing AbstractApexNode instead of ApexNode during tree building
* Extending and using TextFileContent to convert line+column (as is native in Summit) to offset
* Using the new visitor method and interface
* Replace ApexRootNode with BaseApexClass
* Remove AbstractApexNodeBase

[pmd-test]

	2 Messages
📖	Compared to experimental-apex-parser: This changeset changes 51685 violations, introduces 33757 new violations, 15 new errors and 0 new configuration errors, removes 142077 violations, 4 errors and 0 configuration errors. Download full report as build artifact
📖	Compared to master: This changeset changes 12 violations, introduces 6 new violations, 5 new errors and 0 new configuration errors, removes 23 violations, 0 errors and 0 configuration errors. Download full report as build artifact
✅	Compared to experimental-apex-parser: This changeset changes 0 violations, introduces 669266 new violations, 30 new errors and 7 new configuration errors, removes 0 violations, 0 errors and 0 configuration errors. Download full report as build artifact
✅	Compared to master: This changeset changes 11 violations, introduces 5 new violations, 5 new errors and 0 new configuration errors, removes 22 violations, 0 errors and 0 configuration errors. Download full report as build artifact
✅	Compared to experimental-apex-parser: This changeset changes 0 violations, introduces 669145 new violations, 33 new errors and 7 new configuration errors, removes 0 violations, 0 errors and 0 configuration errors. Download full report as build artifact
✅	Compared to master: This changeset changes 10 violations, introduces 5 new violations, 8 new errors and 0 new configuration errors, removes 143 violations, 0 errors and 0 configuration errors. Download full report as build artifact
✅	Compared to experimental-apex-parser: This changeset changes 51616 violations, introduces 34688 new violations, 12 new errors and 0 new configuration errors, removes 142030 violations, 4 errors and 7 configuration errors. Full report
✅	Compared to master: This changeset changes 17 violations, introduces 6 new violations, 2 new errors and 0 new configuration errors, removes 18 violations, 0 errors and 0 configuration errors. Full report

Generated by 🚫 Danger

[adangel]

A bit more useful is this view: master...aaronhurst-google:pmd:experimental-apex-parser - which doesn't contain the changes of pmd/7.0.x.

Or here are the single commits to be reviewed:

• 8880747
• 8412124
• d94f5dd
• 45b3470
• 50a470a
• 293afd2
• 81c53ee
• 9a86989
• 48645de

[adangel]

Sorry that it took so long...

I'm continuing later this week and see, whether it still builds...

[adangel]

I'm going to merge this now into the exeperimental-apex-parser branch.

There are still some things to look at, as the regression tester shows some new errors and differences:

Errors:

• Parse Error: https://github.com/SalesforceLabs/Schedul-o-matic-9000/tree/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Dao.cls
• Parse Error: https://github.com/SalesforceLabs/Schedul-o-matic-9000/tree/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Dao_Test.cls
• Parse Error: https://github.com/nawforce/apex-link/tree/v2.3.0/samples/synthetic/test-classes/force-app/main/default/classes/ServiceImpl.cls
• NPE while applying rule AvoidNonExistentAnnotationsRule on https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/main/classes/fflib_QueryFactory.cls and https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/main/classes/fflib_SecurityUtils.cls

Stacktrace

Caused by: java.lang.NullPointerException
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.checkForNonExistentAnnotation(AvoidNonExistentAnnotationsRule.java:62)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:58)
	at net.sourceforge.pmd.lang.apex.ast.ASTField.acceptApexVisitor(ASTField.java:42)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visit(ApexParserVisitor.java:24)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitApexNode(ApexParserVisitor.java:29)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:352)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:42)
	at net.sourceforge.pmd.lang.apex.ast.ASTUserEnum.acceptApexVisitor(ASTUserEnum.java:18)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visit(ApexParserVisitor.java:24)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitApexNode(ApexParserVisitor.java:29)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:344)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:30)
	at net.sourceforge.pmd.lang.apex.ast.ASTUserClass.acceptApexVisitor(ASTUserClass.java:21)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:20)
	at net.sourceforge.pmd.lang.apex.ast.ASTApexFile.acceptApexVisitor(ASTApexFile.java:61)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.rule.AbstractApexRule.apply(AbstractApexRule.java:17)
	at net.sourceforge.pmd.lang.rule.AbstractDelegateRule.apply(AbstractDelegateRule.java:232)
	at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.applyOnIndex(RuleApplicator.java:75)
	... 9 more

Rule changes:

• ApexDoc is missing many violations now...
• ApexDoc is triggered for static initialization blocks now, e.g. https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/main/classes/fflib_SObjectDomain.cls#L107
• FieldDeclarationShouldBeAtStart is reporting wrong line number (it reports the initialization instead of the declaration)
  • Same with FieldNamingConventions
• EmptyStatementBlock now finds empty catch blocks, e.g. https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_QueryFactoryTest.cls#L270 - is this correct?
• AvoidDeeplyNestedIfStmts now find this: https://github.com/SalesforceLabs/Schedul-o-matic-9000/tree/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Scheduler.cls#L305 and https://github.com/SalesforceLabs/Schedul-o-matic-9000/tree/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Scheduler.cls#L336 - is this correct?

Otherwise it looks pretty promising to replace Jorje soon...