Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #4493: false-positive about MissingStaticMethodInNonInstantiatableClass and @Inject #4495

Merged
merged 1 commit into from
Apr 22, 2023
Merged

[java] Fix #4493: false-positive about MissingStaticMethodInNonInstantiatableClass and @Inject #4495

merged 1 commit into from
Apr 22, 2023

Conversation

LynnBroe
Copy link
Contributor

Describe the PR

This PR excludes com.google.inject.Inject which cause FP.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

jsotuyod
jsotuyod approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@jsotuyod jsotuyod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This is spotless, I'll merge once I get to my other computer.

@jsotuyod jsotuyod changed the title Fix #4493 [java]false-positive about MissingStaticMethodInNonInstantiatableClass and @Inject [java] Fix #4493: false-positive about MissingStaticMethodInNonInstantiatableClass and @Inject Apr 21, 2023
@jsotuyod jsotuyod merged commit cced58c into pmd:master Apr 22, 2023
@adangel adangel added this to the 7.0.0 milestone Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsotuyod jsotuyod jsotuyod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[java] MissingStaticMethodInNonInstantiatableClass: false-positive about @Inject
4 participants
@LynnBroe @pmd-test @jsotuyod @adangel