[apex] Update to apexlink #4528
Conversation
| @@ -63,6 +63,8 @@ void testWellFormedSfdxProjectJsonProducesFunctionalAnalysis() throws Exception | |||
|
|
|||
| assertFalse(analysisInstance.isFailed()); | |||
| }); | |||
|
|
|||
| // TODO: This is failing due to ANTLR versions, 4.9.1 vs 4.8, expect to resolve with apex-dev-tools switch | |||
There was a problem hiding this comment.
That's the reason, why the build is failing - I wonder, why this only now fails, since I see these mismatch antlr versions for a while now...
for reference, these are the messages on stderr:
ANTLR Tool version 4.8 used for code generation does not match the current runtime version 4.9.1
ANTLR Runtime version 4.8 used for parser compilation does not match the current runtime version 4.9.1
ANTLR Tool version 4.8 used for code generation does not match the current runtime version 4.9.1
ANTLR Runtime version 4.8 used for parser compilation does not match the current runtime version 4.9.1
There was a problem hiding this comment.
ok, I understand now, why this test fails only now: Before we initialized Org for every run regardless whether it was a sdfx project. The messages were printed, but for another test already. The messages are printed only once (static initializer in ApexParser).
Now we initialize Org only for sfdx projects and this test case is the first time this is done and therefore the messages are printed there.
I'll keep the TODO but remove the messages from the log, so that the test works.
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/multifile/ApexMultifileAnalysis.java
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger |
|
Thanks for tidying this up. I will get the next update ready to go. |
Describe the PR
Updates apexlink dependency in pmd-apex. This currently updates apexlink to 2.3.5 but is showing a conflict with ANTLR runtime versions, 4.8 vs 4.9.1 which results in a failing test. This will need to be resolved upstream but I thought I would open the PR to show progress on the update. Once we have updated libraries using ANTLR 4.9.1 we should be able to update to latest.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)