Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #4457: false negative about OverrideBothEqualsAndHashcode #4540

Merged
merged 2 commits into from
May 4, 2023
Merged

[java] Fix #4457: false negative about OverrideBothEqualsAndHashcode #4540

merged 2 commits into from
May 4, 2023

Conversation

LynnBroe
Copy link
Contributor

@LynnBroe LynnBroe commented May 3, 2023 •
edited by adangel
Loading

Describe the PR

This PR consider the AnonymousClass.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

pmd-test commented May 3, 2023 •
edited
Loading

1 Message
📖 Compared to master:
This changeset changes 11 violations,
introduces 50 new violations, 0 new errors and 0 new configuration errors,
removes 15 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 47 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala
Rewrite OverrideBothEqualsAndHashcode
c9b5eda 
Support records
Use the rule chain
jsotuyod
jsotuyod approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@jsotuyod jsotuyod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LynnBroe for the PR. @oowekyala fixed all the issues. This should be ready to merge once we add it to the changelog.

@oowekyala oowekyala changed the title Fix #4457: [java]A false negative about OverrideBothEqualsAndHashcode [java] Fix #4457: false negative about OverrideBothEqualsAndHashcode May 3, 2023
@adangel adangel added this to the 7.0.0 milestone May 4, 2023
adangel added a commit to adangel/pmd that referenced this pull request May 4, 2023
@adangel
[doc] Update release notes (pmd#4540, pmd#4457, pmd#4546)
f9b5c98
adangel added a commit that referenced this pull request May 4, 2023
@adangel
Merge pull request #4540 from LynnBroe:issue4457
3a9c361 
[java] Fix #4457: false negative about OverrideBothEqualsAndHashcode #4540
@adangel adangel merged commit c9b5eda into pmd:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsotuyod jsotuyod jsotuyod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
5 participants
@LynnBroe @pmd-test @jsotuyod @adangel @oowekyala