Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #4458: A false positive about RedundantFieldInitializer and @Value #4541

Merged
merged 1 commit into from
May 28, 2023
Merged

[java] Fix #4458: A false positive about RedundantFieldInitializer and @Value #4541

merged 1 commit into from
May 28, 2023

Conversation

LynnBroe
Copy link
Contributor

@LynnBroe LynnBroe commented May 3, 2023 •
edited
Loading

Describe the PR

This PR add an annotation whitelist to exclude @Value

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

pmd-test commented May 3, 2023

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel changed the title Fix #4458: [java]A false positive about RedundantFieldInitializer and @Value [java] Fix #4458: A false positive about RedundantFieldInitializer and @Value May 28, 2023
adangel
adangel approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel added this to the 7.0.0 milestone May 28, 2023
@adangel adangel merged commit 4dd2497 into pmd:master May 28, 2023
3 checks passed
adangel added a commit to adangel/pmd that referenced this pull request May 28, 2023
@adangel
[doc] Update release notes (pmd#4458, pmd#4541)
adb7fa2
adangel added a commit to adangel/pmd that referenced this pull request May 28, 2023
@adangel
Merge pull request pmd#4541 from LynnBroe:issue4458
d6ee587 
[java] Fix pmd#4458: A false positive about RedundantFieldInitializer and @value pmd#4541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[java] RedundantFieldInitializer: false positive with lombok's @Value
3 participants
@LynnBroe @pmd-test @adangel