Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #4434 - FP with ExceptionAsFlowControl #4543

Merged
merged 2 commits into from
May 26, 2023
Merged

[java] Fix #4434 - FP with ExceptionAsFlowControl #4543

merged 2 commits into from
May 26, 2023

Conversation

oowekyala
Copy link
Member

Rewrite ExceptionAsFlowControl to a more efficient form. Change message to be more informative.
Rewrite description of the rule.

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala
Fix pmd#4434
296d259 
Rewrite ExceptionAsFlowControl to a more efficient form.
Change message to be more informative.
Rewrite description of the rule.
@oowekyala oowekyala added this to the 7.0.0 milestone May 3, 2023
@pmd-test
Copy link

pmd-test commented May 3, 2023 •
edited

1 Message
📖 Compared to master:
This changeset changes 233 violations,
introduces 54 new violations, 0 new errors and 0 new configuration errors,
removes 36 violations, 0 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 223 violations,
introduces 54 new violations, 0 new errors and 0 new configuration errors,
removes 36 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

oowekyala added a commit that referenced this pull request May 26, 2023
@oowekyala
Update release notes, ref #4543
7e07ee8
@oowekyala oowekyala merged commit 1474ab5 into pmd:master May 26, 2023
3 checks passed
@oowekyala oowekyala deleted the issue4434-exceptionasflowcontrol branch May 26, 2023 09:24
adangel added a commit to adangel/pmd that referenced this pull request May 28, 2023
@adangel
[doc] Update release notes (pmd#4492, pmd#4543)
dea05bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsotuyod jsotuyod jsotuyod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[java] [7.0-rc1] ExceptionAsFlowControl when simply propagating
3 participants
@oowekyala @pmd-test @jsotuyod