Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #4492: GuardLogStatement gives false positive when argument is a Java method reference #4553

Merged
merged 1 commit into from
May 28, 2023
Merged

[java] Fix #4492: GuardLogStatement gives false positive when argument is a Java method reference #4553

merged 1 commit into from
May 28, 2023

Conversation

anastasiia-koba
Copy link

@anastasiia-koba anastasiia-koba commented May 6, 2023 •
edited
Loading

Describe the PR

GuardLogStatement gives false positive when a Java method reference is used, although method references are equivalent to lambdas.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

pmd-test commented May 6, 2023

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@jsotuyod jsotuyod changed the title Fix #4492: [java] GuardLogStatement gives false positive when argument is a Java method reference [java] Fix #4492: GuardLogStatement gives false positive when argument is a Java method reference May 6, 2023
@adangel adangel added this to the 7.0.0 milestone May 28, 2023
adangel
adangel approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adangel adangel merged commit 5aa917b into pmd:master May 28, 2023
adangel added a commit to adangel/pmd that referenced this pull request May 28, 2023
@adangel
Merge pull request pmd#4553 from anastasiia-koba:issue-4492
7584ba3 
[java] Fix pmd#4492: GuardLogStatement gives false positive when argument is a Java method reference pmd#4553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsotuyod jsotuyod jsotuyod approved these changes

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[java] GuardLogStatement gives false positive when argument is a Java method reference
4 participants
@anastasiia-koba @pmd-test @jsotuyod @adangel