Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Change completion generation to runtime #4594

Merged
merged 7 commits into from
Oct 20, 2023

Conversation

jsotuyod
Copy link
Member

@jsotuyod jsotuyod commented Jun 8, 2023

This implements what was suggested in #4446 (comment)

  • We no longer ship a pre-built completion script
  • A hidden subcommand is available to generate it dynamically based on actually available languages.
  • We update docs everywhere accordingly

 - We no longer ship a pre-built completion script
 - A hidden subcommand is available to generate it dynamically based on
   actually available languages.
 - We update docs everywhere accordingly.
@jsotuyod jsotuyod marked this pull request as draft June 8, 2023 03:52
@pmd-test
Copy link

pmd-test commented Jun 8, 2023

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
No regression tested rules have been changed.

Generated by 🚫 Danger

@jsotuyod jsotuyod marked this pull request as ready for review June 9, 2023 16:03
Copy link
Member

@oowekyala oowekyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

docs/pages/pmd/userdocs/installation.md Outdated Show resolved Hide resolved
pmd-cli/src/main/java/net/sourceforge/pmd/cli/PmdCli.java Outdated Show resolved Hide resolved
@adangel adangel mentioned this pull request Aug 22, 2023
5 tasks
@adangel

This comment was marked as resolved.

@adangel adangel self-requested a review October 19, 2023 09:53
@adangel adangel added this to the 7.0.0 milestone Oct 19, 2023
@adangel adangel added the in:cli Affects the PMD Command Line Interface label Oct 19, 2023
@jsotuyod
Copy link
Member Author

After and extremely long delay, for which I'm very sorry, this is finally done. Took care of all your feedback, including merging back from master and dealing with the changes introduced in #4397.

Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

adangel added a commit that referenced this pull request Oct 20, 2023
adangel added a commit that referenced this pull request Oct 20, 2023
[cli] Change completion generation to runtime #4594
@adangel adangel merged commit 2e4e127 into pmd:master Oct 20, 2023
3 checks passed
@jsotuyod jsotuyod deleted the runtime-completion branch October 20, 2023 11:10
adangel added a commit that referenced this pull request Feb 22, 2024
Note: java and javascript are needed for tests in cli

Refs #4594
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:cli Affects the PMD Command Line Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants