-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Change completion generation to runtime #4594
Conversation
- We no longer ship a pre-built completion script - A hidden subcommand is available to generate it dynamically based on actually available languages. - We update docs everywhere accordingly.
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool!
This comment was marked as resolved.
This comment was marked as resolved.
After and extremely long delay, for which I'm very sorry, this is finally done. Took care of all your feedback, including merging back from master and dealing with the changes introduced in #4397. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/LawOfDemeter.xml
Show resolved
Hide resolved
[cli] Change completion generation to runtime #4594
Note: java and javascript are needed for tests in cli Refs #4594
This implements what was suggested in #4446 (comment)