Allow byte[] as no-varargs final argument #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1767,7 +1767,7 @@ having to deal with the creation of an array. | |||
| <properties> | |||
| <property name="xpath"> | |||
| <value><![CDATA[ | |||
| //FormalParameters/FormalParameter[position()=last() and @Array='true' and @Varargs='false'] | |||
| //FormalParameters/FormalParameter[position()=last() and @Array='true' and @Varargs='false' and not (./Type/ReferenceType/PrimitiveType[@Image='byte']) and not (./Type/PrimitiveType[@Image='byte'])] | |||
There was a problem hiding this comment.
I've removed the last condition as it doesn't seem to be required (and not (./Type/PrimitiveType[@Image='byte'])).
If this is really needed - please provide a test case.
There was a problem hiding this comment.
Sorry for not providing test-case for the second case. It was a quick edit.
The AST parsed is different in those two cases
byte[] data byte data[]I've created another pull request with test-cases and proposed solution.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow byte[] as no-vargars last argument.
Example:
public void writeToFile(File theFile, byte[] data) {
// ..
}