Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Make ClasspathClassLoader::getResource child first #4621

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

oowekyala
Copy link
Member

Describe the PR

This makes it so that one can use the auxclasspath to include a standard lib for a different java version than the one on PMD's own classpath.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.0.0 milestone Jul 2, 2023
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll look at the failing Windows unit test (ClassLoadingChildFirstTest.testClassLoading:41 � InvalidPath Illegal char <:> at index 2: /D:/a/pmd/pmd/pmd-java/target/test-classes/net/sourceforge/pmd/lang/java/symbols/custom_java_lang.jar) and merge it afterwards.

@pmd-test
Copy link

pmd-test commented Jul 6, 2023

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 2 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel merged commit 3e2de67 into pmd:master Jul 6, 2023
3 checks passed
@adangel adangel added the in:type-resolution Affects the type resolution code label Jul 6, 2023
@oowekyala oowekyala deleted the issue4620-classloading-child-first branch May 13, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:type-resolution Affects the type resolution code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants