Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] fix #4634 - JUnit4TestShouldUseTestAnnotation false positive with TestNG #4637

Merged
merged 1 commit into from
Aug 5, 2023
Merged

[java] fix #4634 - JUnit4TestShouldUseTestAnnotation false positive with TestNG #4637

merged 1 commit into from
Aug 5, 2023

Conversation

krdabrowski
Copy link
Contributor

@krdabrowski krdabrowski commented Aug 4, 2023 •
edited by adangel
Loading

Changes:

  • fixed the JUnit4TestShouldUseTestAnnotation rule for TestNG,
  • added test
  • updated changelog

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@krdabrowski
Refs pmd#4634
91d7cc2 
- fix the JUnit4TestShouldUseTestAnnotation rule for TestNG,
- add test
- update changelog
@krdabrowski krdabrowski marked this pull request as ready for review August 4, 2023 11:59
@adangel adangel added this to the 7.0.0 milestone Aug 5, 2023
adangel
adangel approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@pmd-test
Copy link

pmd-test commented Aug 5, 2023

1 Message
📖 Compared to master:
This changeset changes 82 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 11 violations, 8 errors and 7 configuration errors.
Full report

Generated by 🚫 Danger

adangel added a commit that referenced this pull request Aug 5, 2023
@adangel
[doc] Update release notes (#4637, #4634)
8523adc
adangel added a commit that referenced this pull request Aug 5, 2023
@adangel
Merge pull request #4637 from krdabrowski:fix-4634
1021b3b 
[java] fix #4634 - JUnit4TestShouldUseTestAnnotation false positive with TestNG #4637
@adangel adangel merged commit 91d7cc2 into pmd:master Aug 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[java] JUnit4TestShouldUseTestAnnotation false positive with TestNG
3 participants
@krdabrowski @pmd-test @adangel