[javascript] CPD: Added support for decorator notation #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to resolve the following error on a typescript file: [main] ERROR net.sourceforge.pmd.cli - Error while tokenizing: Lexical error in file '.\TableList.js' at line 67, column 1: "@" (64), after : "" (in lexical state DEFAULT)
wener-tiobe
changed the title
|
I'll add a unit test too. |
Generated by 🚫 Danger |
wener-tiobe
changed the title
adangel
added
the
in:grammar
adangel
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
Thanks!
I'll change the grammar myself before merging.
In case, someone wonders: Decorators are an experimental feature of ecmascript not yet part of the standard, see https://github.com/tc39/proposal-decorators and tc39/ecma262#2417
See https://arai-a.github.io/ecma262-compare/snapshot.html?pr=2417#sec-decorators for the proposed standard document.
...javascript/src/test/resources/net/sourceforge/pmd/lang/ecmascript/cpd/testdata/decorator.txt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This is to resolve the following error on a javascript file:
[main] ERROR net.sourceforge.pmd.cli - Error while tokenizing: Lexical error in file '.\TableList.js' at
line 67, column 1: "@" (64), after : "" (in lexical state DEFAULT)
Ready?
./mvnw clean verifypasses (checked automatically by github actions)