[core] Fix line/col numbers in TokenMgrError #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref pmd#4635 Col number of zero may happen when the error is reported on a newline. In the rest of PMD a newline is considered to sit at the last index of the previous line. So the index is now the first character of the next line, which is slightly wrong but that doesn't matter much.
Generated by 🚫 Danger |
adangel
force-pushed
the
issue4635-cpd-lexical-error
branch
from
d2fe3f1
to
fb0e9c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Not sure why I forgot to pull request this. Maybe laziness to write tests. Will add one soon.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)