[groovy] Support Groovy to 3 and 4 and CPD suppressions #4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We now support parsing all Groovy features from Groovy 3 and 4 - Support for 5 is not included as it would not work with Java 8 - Along the way, this also fixes pmd#4674
|
I still need to update documentation and changelog appropriately. Thankfully the base implementation we did to support both JavaCC a Antlr was flexible enough to accommodate this one, even if it's using a different Antlr and needed new implementations here and there. Groovy 5 requires JRE 11 to run, and since it attempts to load immediately upon being in the classpath (hence the logs seen in #4674) I didn't dare to use it. |
Generated by 🚫 Danger |
adangel
added
an:enhancement
adangel
approved these changes
Dec 11, 2023
adangel
added a commit
that referenced
this pull request
Dec 11, 2023
adangel
added a commit
that referenced
this pull request
Dec 11, 2023
[groovy] Support Groovy to 3 and 4 and CPD suppressions #4726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPD-OFF/CPD-ONsuppressionsDescribe the PR
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)