Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] EmptyControlStatementRule: Add allowCommentedBlocks property #4754

Merged
merged 1 commit into from Dec 1, 2023

Conversation

bergander
Copy link
Contributor

@bergander bergander commented Nov 27, 2023

Describe the PR

Rule: EmptyControlStatement

Adds a property to EmptyControlStatementRule to allow empty block containing comments. It may be good to be able to explain why a condition does not require logic.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel changed the title Add allowCommentedBlocks property to EmptyControlStatementRule [java] EmptyControlStatementRule: Add allowCommentedBlocks property Dec 1, 2023
@adangel adangel added the an:enhancement An improvement on existing features / rules label Dec 1, 2023
@pmd-test
Copy link

pmd-test commented Dec 1, 2023

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel added this to the 7.0.0 milestone Dec 1, 2023
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

adangel added a commit that referenced this pull request Dec 1, 2023
adangel added a commit that referenced this pull request Dec 1, 2023
[java] EmptyControlStatementRule: Add allowCommentedBlocks property #4754
@adangel adangel merged commit de2a7e1 into pmd:master Dec 1, 2023
3 checks passed
adangel added a commit to adangel/pmd that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
an:enhancement An improvement on existing features / rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants